Closed
Conversation
davidv1992
force-pushed
the
service-ssh-userauth
branch
from
074bf79 to
fd50019
Compare
djc
reviewed
Jan 16, 2026
| mod proto; | ||
| use proto::{read, Decode, Decoded, Encode, ReadState}; | ||
| mod service; | ||
| mod userauth; |
| Error, | ||
| }; | ||
|
|
||
| pub(crate) struct SshUserauth { |
Owner
There was a problem hiding this comment.
Nit: drop the Ssh prefix, spell as UserAuth.
| } | ||
|
|
||
| #[expect(unused)] | ||
| pub(crate) fn poll_complete<S: Service>( |
| } | ||
| } | ||
|
|
||
| impl Service for SshUserauth { |
Owner
There was a problem hiding this comment.
I think there is too much stuff in this commit, suggest splitting it up into smaller steps.
davidv1992
force-pushed
the
service-ssh-userauth
branch
from
fd50019 to
322d058
Compare
bjorn3
force-pushed
the
service-ssh-userauth
branch
3 times, most recently
from
83873ae to
27d523f
Compare
This does not yet implement proper handling of sequence numbers. That is a fairly significant refactor which should be done as part of the patches for the encryption/decryption channels.
This makes the packet type available on all messages, simplifying error handling downstream as it no longer needs to deal with the anomalous case of a completely empty packet.
bjorn3
force-pushed
the
service-ssh-userauth
branch
from
27d523f to
986df04
Compare
Owner
|
Took parts of this to build a simpler implementation in #103. I think there's too much complexity for now in the user auth state machine, so will close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the work in #85, uses the design from #81